[SCRIPT] Advanced Mineral Scanner v1.31 09/12/06

[A dJ]

Really weird! I can't find a solution

Maybe it's a compatibility issue with another script, I just today noticed someone else's script uses the same ware slot as mine.

[Jsangster]

stupid question, did you buy the advanced mineral scanner from a teladi eq dock

[Blacjacmac]

I've still yet to see it for sale. Only sectors I havent checked for it are Spaceweed Drift, Bad Debt & Ministry of finance. Assuming it's in one of those systems?

[Jsangster]

try the eq dock in ianumus zura (spelling)

[AalaarDB]

Here's some tips. For performance, use either of these 2 commands found in universe section:

Code: Select all

$= get ship array of race Player clsas/type Ship

Code: Select all

$= $sector-> get player owned ship array from sector

Either of those will probably be faster. One is sector based and one is universe based so you'll have to decide which you want. Also, you have the wait in the innermost loop. This is a bad spot for several reasons. First, during the scanning the current ship could be destroyed. This is best solved by checking if the ship exists once, then scanning all asteroids with no wait. Second, you wait whether or not an asteroid has been scanned or not. And a few minor reasons.

Also, you should check whether or not the sector exists before trying to scan there.

There's a lot of other stuff that could be improved, but I'll let you figure it out on your own.

[A dJ]

Thanks for browsing through my code AalaarDB, really appreciated.

The wait stays where it is though. I put it there intentionally (unless it can be done differently) (Yea I've read Burianek's post too) Also you should not assume I'll figure things out on my own, I'm still an amateur scripter.

Anyway before I update, I'd like to fix/improve as much as possible. So any or all issues should be posted ASAP. This I do to not annoy anyone with frequent updates.

[A dJ]

Heh, I figured people can get annoyed for a whole lot of reasons anyway.

Update.

[AalaarDB]

Better. I still stand by saying you'll figure things out. I did in X2, I started out with no experience.
You could replace the goto labels with continues, they do the same thing and are considered better programming practice.

[DaveyP]

It works fine in my Mammoth, but not in my Nova. Wierd!

[A dJ]

It should work with all of your ships, just checked the nova myself and could not find a problem.

[Grumble314]

Just a quick quest i don't see Trade Command Software MK3 on teladi equipment docks anymore was this script the cause?

[dunnno]

I am using this mod and the mk3's are still there on the Teladi equipment docks.

[Grumble314]

Hmm k will have to search and see what other script might be causing it. I have them at Inanamus Zura but not at Ceo's Buckzoid just seemed like the most likely candidate so thought I would ask.

[A dJ]

Update available.

[klaatu]

What's up with this?

"This package file was created by a newer version. You need version 2.00 to install it."

I assume this means version 2.00 of Cycrow's installer, but there is no such thing. Not released anyway.

[A dJ]

Sorry should have mentioned, grab v1.23 Beta.

[Cycrow]

it means it needs an installer capable of installer v2.00 package file format which is the current beta

althou soon it'll be the full version as the beta is almost finished

[klaatu]

Sorry should have mentioned, grab v1.23 Beta.

No thanks. Betas are supposed to be used only by testers, and it doesn't seem right to me that a released package should require use of a beta installer. I'll wait until it's out of beta.

[A dJ]

Ok if you will, I won't. It's just as stable as 1.21 IMO.

Oh and besides, if you used my script before, it was also kinda beta. (although I didn't mention it)

[klaatu]

OK, something strange. Using new Script Installer 1.30, and if I try to install this script when the .spk file has the name 'X3-AMS-122.spk' I get an error message from the Script Installer that says 'unable to open script package'. If I rename it to 'AMS-122.spk' it installs fine. I tried it several times, deleting the file and redownloading it even, all with the same results. Even renaming the file back to the default name and the error comes back. Very strange. Only thing I can think of is some sort of weird bug in the Script Installer program. Oh well...